Port RateLimiter fixes from Lucene 4.8.1, #1381#1420
Open
paulirwin wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
An update... there was the potential for this test to be flaky (per its own comment in Java). I ran it many times on my machine and it was passing reliably, but there was the possibility (particularly on slow ADO agents I would presume) for this to possibly fail due to timing. It turns out there were subsequent updates to this test in Lucene 6.0.0 and Lucene 7.0.0 in commits 090b804 and a893aaa that improved the reliability of this test on slow machines, so I went ahead and backported those as well. |
19 tasks
paulirwin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport RateLimiter fixes from Lucene 4.8.1
Partial #1381 (Batch 2)
Description
This backports the LUCENE-5641 RateLimiter fix from Lucene 4.8.1. The original impetus for this fix in Lucene was not a problem in .NET because we were already doing the integer division correctly, but this does fix a race by synchronizing around the logic too. So it's worth backporting for that, as well as to stay in sync with upstream. And, this adds a test as well.
See this comment for some more context: #1381 (comment)